Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PACs and xtensa-lx-rt package #761

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Update PACs and xtensa-lx-rt package #761

merged 2 commits into from
Aug 29, 2023

Conversation

jessebraham
Copy link
Member

  • Update xtensa-lx-rt to the latest version
    • I'm not 100% sure the linker script changes are necessary, but I've included them just to be consistent with the RISC-V devices' scripts
  • Update PACs to their latest versions
    • There was a new release of svd2rust, and it seems the traits have changed slightly
    • We had a couple helper functions which previously relied on these traits which broke as a result
    • I've simply removed these helpers as they were, IMO, of limited utility to begin with

@jessebraham jessebraham changed the title Fixes/deps Update PACs and xtensa-lx-rt package Aug 29, 2023
@jessebraham
Copy link
Member Author

(As usual, forgot to add the skip-changelog label)

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Aug 29, 2023
bjoernQ
bjoernQ approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessebraham jessebraham merged commit 0795770 into esp-rs:main Aug 29, 2023
@jessebraham jessebraham deleted the fixes/deps branch August 29, 2023 14:59
playfulFence pushed a commit to playfulFence/esp-hal that referenced this pull request Sep 26, 2023
@jessebraham @playfulFence
Update PACs and xtensa-lx-rt package (esp-rs#761)
788f8db 
* Update `xtensa-lx-rt` package and Xtensa linker scripts

* Update PACs and make required changes to get things building again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@MabezDev MabezDev Awaiting requested review from MabezDev

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessebraham @bjoernQ